Make sure that we can build Rust extensions on Windows.
Details
Details
- Reviewers
mbthomas quark - Group Reviewers
Restricted Project - Commits
- rFBHGXccb7df352f67: distutils_rust: teach distutils to look for windows libs
- set USERUST=1
- run FB build script, which invokes fb-hgext's setup.py
- see it not failing
Diff Detail
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
distutils_rust/__init__.py | ||
---|---|---|
78–82 | This feels duplicated with line 87. Could you do something like: if platform.startswith('win-'): name = '%s.dll' % ext.name else if platform.startswith('macosx'): name = 'lib%s.dylib' % ext.name else: name = 'lib%s.so' % ext.name return os.path.join(..., name) |
This feels duplicated with line 87. Could you do something like: