This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1598

contrib: ban find(1)'s -printf operator, as it is a GNU-ism
ClosedPublic

Authored by durin42 on Dec 5 2017, 5:03 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG91a7204631f1: contrib: ban find(1)'s -printf operator, as it is a GNU-ism
rHG22956c17aa18: contrib: ban find(1)'s -printf operator, as it is a GNU-ism
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Dec 5 2017, 5:03 PM
yuja accepted this revision.Dec 6 2017, 8:29 AM
This revision is now accepted and ready to land.Dec 6 2017, 8:29 AM
Closed by commit rHG22956c17aa18: contrib: ban find(1)'s -printf operator, as it is a GNU-ism (authored by durin42). · Explain WhyDec 6 2017, 9:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (2 lines)

Diff 4135

contrib/check-code.py

(r'seq ', "don't use 'seq', use $TESTDIR/seq.py"), (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
(r'\butil\.Abort\b', "directly use error.Abort"), (r'\butil\.Abort\b', "directly use error.Abort"),
(r'\|&', "don't use |&, use 2>&1"), (r'\|&', "don't use |&, use 2>&1"),
(r'\w = +\w', "only one space after = allowed"), (r'\w = +\w', "only one space after = allowed"),
(r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"), (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
(r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
(r'grep.* -[ABC]', "don't use grep's context flags"), (r'grep.* -[ABC]', "don't use grep's context flags"),
(r'find.*-printf',
"don't use 'find -printf', it doesn't exist on BSD find(1)"),
], ],
# warnings # warnings
[ [
(r'^function', "don't use 'function', use old style"), (r'^function', "don't use 'function', use old style"),
(r'^diff.*-\w*N', "don't use 'diff -N'"), (r'^diff.*-\w*N', "don't use 'diff -N'"),
(r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"), (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),
(r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"), (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
(r'kill (`|\$\()', "don't use kill, use killdaemons.py") (r'kill (`|\$\()', "don't use kill, use killdaemons.py")