This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1602

distutils_rust: support windows python extension filenames
ClosedPublic

Authored by mbthomas on Dec 6 2017, 6:51 AM.
Tags
None
Subscribers
None

Details

Reviewers
ikostia
Group Reviewers
Restricted Project
Commits
rFBHGXc0a41e35fdc8: distutils_rust: support windows python extension filenames
Summary

On Windows, binary python extensions should have a .pyd file extension.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbthomas created this revision.Dec 6 2017, 6:51 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 6 2017, 6:51 AM
ikostia accepted this revision.Dec 6 2017, 6:54 AM
This revision is now accepted and ready to land.Dec 6 2017, 6:54 AM
Closed by commit rFBHGXc0a41e35fdc8: distutils_rust: support windows python extension filenames (authored by mbthomas). · Explain WhyDec 12 2017, 7:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdistutils_rust/__init__.py (7 lines)

Diff 4405

distutils_rust/__init__.py

"""Returns the filename of the build output.""" """Returns the filename of the build output."""
if self.inplace: if self.inplace:
# the inplace option requires to find the package directory # the inplace option requires to find the package directory
# using the build_py command for that # using the build_py command for that
build_py = self.get_finalized_command('build_py') build_py = self.get_finalized_command('build_py')
package_dir = build_py.get_package_dir(ext.package) package_dir = build_py.get_package_dir(ext.package)
else: else:
package_dir = os.path.join(self.build_lib, *ext.package.split('.')) package_dir = os.path.join(self.build_lib, *ext.package.split('.'))
return os.path.join(package_dir, ext.name + '.so') platform = distutils.util.get_platform()
if platform.startswith('win-'):
name = ext.name + '.pyd'
else:
name = ext.name + '.so'
return os.path.join(package_dir, name)
def build_ext(self, ext): def build_ext(self, ext):
log.info("building '%s' extension", ext.name) log.info("building '%s' extension", ext.name)
cmd = ['cargo', 'build', '--manifest-path', ext.manifest] cmd = ['cargo', 'build', '--manifest-path', ext.manifest]
if not self.debug: if not self.debug:
cmd.append('--release') cmd.append('--release')