This is an archive of the discontinued Mercurial Phabricator instance.

tests: remove {a..h} bashism from remotenames
ClosedPublic

Authored by durin42 on Dec 6 2017, 9:25 AM.

Details

Summary

I'm not bothering with a check-code test because this is a weird
construct that I didn't even know existed before it was breaking the
BSD build, and it also appears to fail if /bin/sh is dash like it is
on our Linux builder.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Dec 6 2017, 9:25 AM
durin42 edited the summary of this revision. (Show Details)Dec 6 2017, 9:27 AM
pulkit accepted this revision.Dec 6 2017, 9:45 AM
pulkit added a subscriber: pulkit.

Sigh, thanks again for fixing this. I will make sure I stop using this pattern.

krbullock accepted this revision.Dec 6 2017, 2:43 PM
krbullock added a subscriber: krbullock.

LGTM.

This revision is now accepted and ready to land.Dec 6 2017, 2:43 PM
This revision was automatically updated to reflect the committed changes.