Page MenuHomePhabricator

infinitepush: write backup state file atomically
AcceptedPublic

Authored by stash on Dec 8 2017, 11:51 AM.

Details

Reviewers
mbthomas
quark
Group Reviewers
Restricted Project
Test Plan

Run infinitepush tests

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

stash created this revision.Dec 8 2017, 11:51 AM
Herald added a reviewer: Restricted Project. ยท View Herald TranscriptDec 8 2017, 11:51 AM
quark accepted this revision.Dec 8 2017, 10:01 PM
quark added a subscriber: quark.
quark added inline comments.
infinitepush/backupcommands.py
842

json.dump({...}, f) could avoid creating the temporary string. Although it probably does not make a visible difference here.

This revision is now accepted and ready to land.Dec 8 2017, 10:01 PM