This is an archive of the discontinued Mercurial Phabricator instance.

infinitepush: write backup state file atomically
AcceptedPublic

Authored by stash on Dec 8 2017, 11:51 AM.

Reviewers

mbthomas
quark

Group Reviewers

Restricted Project

Test Plan

Run infinitepush tests

Repository

rFBHGX Facebook Mercurial Extensions

Lint

Lint Skipped

Unit

Unit Tests Skipped

quark added a subscriber: quark.

quark added inline comments.

infinitepush/backupcommands.py
842	`json.dump({...}, f)` could avoid creating the temporary string. Although it probably does not make a visible difference here.

This revision is now accepted and ready to land.Dec 8 2017, 10:01 PM

			Path	Packages
M			infinitepush/backupcommands.py (2 lines)

	result.localbookmarks = state['bookmarks']			result.localbookmarks = state['bookmarks']
	return result			return result
	except (ValueError, KeyError, TypeError) as e:			except (ValueError, KeyError, TypeError) as e:
	ui.warn(_('corrupt file: %s (%s)\n') % (_backupstatefile, e))			ui.warn(_('corrupt file: %s (%s)\n') % (_backupstatefile, e))
	return backupstate()			return backupstate()
	return backupstate()			return backupstate()

	def _writelocalbackupstate(vfs, heads, bookmarks):			def _writelocalbackupstate(vfs, heads, bookmarks):
	with vfs(_backupstatefile, 'w') as f:			with vfs(_backupstatefile, 'w', atomictemp=True) as f:
	f.write(json.dumps({'heads': list(heads), 'bookmarks': bookmarks}))			f.write(json.dumps({'heads': list(heads), 'bookmarks': bookmarks}))
				quarkUnsubmitted Not Done `json.dump({...}, f)` could avoid creating the temporary string. Although it probably does not make a visible difference here. quark: `json.dump({...}, f)` could avoid creating the temporary string. Although it probably does not…

	def _readbackupgenerationfile(vfs):			def _readbackupgenerationfile(vfs):
	try:			try:
	with vfs(_backupgenerationfile) as f:			with vfs(_backupgenerationfile) as f:
	return int(f.read())			return int(f.read())
	except (IOError, OSError, ValueError):			except (IOError, OSError, ValueError):
	return 0			return 0

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4255			Dec 8 2017, 11:51 AM	★	★