This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1619

highlight: eagerly discover plugin lexers while demandimport is off
ClosedPublic

Authored by durin42 on Dec 8 2017, 4:23 PM.

Details

Reviewers
quark
yuja
Group Reviewers
hg-reviewers
Commits
rHG169d66db5920: highlight: eagerly discover plugin lexers while demandimport is off
Summary

Since highlight is only relevant for servers, it seems worthwhile to
just trigger this eagerly, which avoids really weird traceback
problems caused by demandimport messing with some of the lexer plugins.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Dec 8 2017, 4:23 PM
quark accepted this revision.Dec 8 2017, 5:49 PM
yuja accepted this revision.Dec 8 2017, 8:32 PM
This revision is now accepted and ready to land.Dec 8 2017, 8:32 PM
Closed by commit rHG169d66db5920: highlight: eagerly discover plugin lexers while demandimport is off (authored by durin42). · Explain WhyDec 8 2017, 8:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/highlight/highlight.py (4 lines)

Diff 4280

hgext/highlight/highlight.py

encoding, encoding,
util, util,
) )
with demandimport.deactivated(): with demandimport.deactivated():
import pygments import pygments
import pygments.formatters import pygments.formatters
import pygments.lexers import pygments.lexers
import pygments.plugin
import pygments.util import pygments.util
for unused in pygments.plugin.find_plugin_lexers():
pass
highlight = pygments.highlight highlight = pygments.highlight
ClassNotFound = pygments.util.ClassNotFound ClassNotFound = pygments.util.ClassNotFound
guess_lexer = pygments.lexers.guess_lexer guess_lexer = pygments.lexers.guess_lexer
guess_lexer_for_filename = pygments.lexers.guess_lexer_for_filename guess_lexer_for_filename = pygments.lexers.guess_lexer_for_filename
TextLexer = pygments.lexers.TextLexer TextLexer = pygments.lexers.TextLexer
HtmlFormatter = pygments.formatters.HtmlFormatter HtmlFormatter = pygments.formatters.HtmlFormatter
SYNTAX_CSS = ('\n<link rel="stylesheet" href="{url}highlightcss" ' SYNTAX_CSS = ('\n<link rel="stylesheet" href="{url}highlightcss" '