This patch adds logic to check whether a push is an infinitepush or not from
an old client or client who don't have infinitepush client logic.
Details
- Reviewers
durham - Group Reviewers
Restricted Project
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Could this have a test? Is there a config knob to disable bundle2 or force bundle1?
infinitepush/__init__.py | ||
---|---|---|
1055 | I'd make it clear that this will have performance impact. | |
1080 | Can we add a comment saying this could require a lot of memory, and that we might want to move this to being stored on disk in the future? | |
1108 | I'd rename this supportoldclients, since it's a server configuration. |
Status update: While adding tests, I found that I am reading the part twice, once for adding in bundlepart and once for the copied part. Since I can't read that twice, I need to do better here with the logic involved.
I'd make it clear that this will have performance impact.