Page MenuHomePhabricator

pushrebase: remove check-bookmarks parts generator
ClosedPublic

Authored by ikostia on Dec 11 2017, 12:37 PM.

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX473dc7b7661a: pushrebase: remove check-bookmarks parts generator
Summary

[1] adds a new check which moves bookmarks race check earlier, and this conflicts
with pushrebase. In reality pushrebase-enabled repos don't need this check
anyway, so we can just remove this generator.

[1] https://www.mercurial-scm.org/repo/hg/rev/ad5f2b923b0d

Test Plan
  • run pushrebase tests, see them change their status from failing to passing

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ikostia created this revision.Dec 11 2017, 12:37 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2017, 12:37 PM
ikostia planned changes to this revision.Dec 11 2017, 12:55 PM
ikostia requested review of this revision.Dec 11 2017, 1:15 PM

This is needed, but only fixes tests together with the other fixes, so the description is slightly incorrect.

quark accepted this revision.Dec 11 2017, 2:54 PM
This revision is now accepted and ready to land.Dec 11 2017, 2:54 PM
This revision was automatically updated to reflect the committed changes.