This is an archive of the discontinued Mercurial Phabricator instance.

copies: always respect matcher arg to _forwardcopies()
ClosedPublic

Authored by martinvonz on Dec 14 2017, 8:01 PM.

Details

Summary

The function would ignore the matcher if the dirstate copies were
requested. It doesn't matter in practice because all callers used the
returned map only for looking up specific files from and those files
had already been filtered by the matcher (AFACT). Still, it's a little
confusing, so let's make it clearer by respecting the matcher in this
case too.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Dec 14 2017, 8:01 PM
yuja accepted this revision.Dec 15 2017, 8:38 AM
This revision is now accepted and ready to land.Dec 15 2017, 8:38 AM
This revision was automatically updated to reflect the committed changes.