This is an archive of the discontinued Mercurial Phabricator instance.

sparse: properly error out when absolute paths are used
ClosedPublic

Authored by ikostia on Jul 21 2017, 2:22 PM.
Tags
None
Subscribers
None

Details

Summary

Current behavior does not even do what it says, let alone the right thing.

Test Plan
  • rt

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ikostia created this revision.Jul 21 2017, 2:22 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2017, 2:22 PM
mjpieters accepted this revision.Jul 21 2017, 7:04 PM

For clarity: we already basically aborted when there were absolute paths, but this change makes it an actual error rather than an incorrectly worded warning.

This revision is now accepted and ready to land.Jul 21 2017, 7:04 PM
This revision was automatically updated to reflect the committed changes.