This is an archive of the discontinued Mercurial Phabricator instance.

scmutil: add warnmessage argument to unhidehashlikerevs function
AbandonedPublic

Authored by pulkit on Jan 6 2018, 1:48 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Summary

While adding support for unhiding revs for commands which are not just read
only, a need for showing custom messages for different command is found. This
patch adds a new optional argument to unhidehashlikerevs() function which if
passed will be the warning message displayed to user provided the function is
called in "warn" mode.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Jan 6 2018, 1:48 AM
yuja requested changes to this revision.Jan 10 2018, 7:52 AM
yuja added a subscriber: yuja.
yuja added inline comments.
mercurial/scmutil.py
1350

_() must wrap a string literal.

FWIW, hiddentype == 'warn' might not be that useful. See the
comment on the next patch.

This revision now requires changes to proceed.Jan 10 2018, 7:52 AM
pulkit abandoned this revision.Mar 1 2018, 7:52 PM