This is an archive of the discontinued Mercurial Phabricator instance.

exchange: use context manager for locks and transaction in unbundle()
ClosedPublic

Authored by martinvonz on Jan 10 2018, 2:22 PM.

Details

Summary

Note that the transactionmanager doesn't actually create a transaction

  • that is done the first time .transaction() is called on it (if at

all). Consequently, .close() and .release() won't do anything if no
transaction has been created. This makes it a little unusual, but it
still works as a context manager.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 10 2018, 2:22 PM
durin42 accepted this revision.Jan 10 2018, 5:45 PM
This revision is now accepted and ready to land.Jan 10 2018, 5:45 PM
This revision was automatically updated to reflect the committed changes.