This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1874

formatting: enforce clang-format on all .cc files as well as .c files
ClosedPublic

Authored by durin42 on Jan 17 2018, 4:31 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG39499bc31fcd: formatting: enforce clang-format on all .cc files as well as .c files
rHGcb55f93bb29c: formatting: enforce clang-format on all .cc files as well as .c files
Summary

As part of my upcoming fuzzer patch we're going to grow some .cc
files. They're not part of the release build (they're only used for
fuzzing, which requires clang 6 which in turn implies a working C++
compiler), so I'm not terribly worried about growing some C++ files.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 17 2018, 4:31 PM
indygreg accepted this revision.Jan 17 2018, 4:37 PM
This revision is now accepted and ready to land.Jan 17 2018, 4:37 PM
Closed by commit rHGcb55f93bb29c: formatting: enforce clang-format on all .cc files as well as .c files (authored by durin42). · Explain WhyJan 17 2018, 4:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MMakefile (2 lines)
Mtests/test-check-clang-format.t (2 lines)

Diff 4860

Makefile

$(MAKE) -f $(HGROOT)/contrib/Makefile.python PYTHONVER=$* PREFIX=$(HGPYTHONS)/$* python ) $(MAKE) -f $(HGROOT)/contrib/Makefile.python PYTHONVER=$* PREFIX=$(HGPYTHONS)/$* python )
cd tests && $(HGPYTHONS)/$*/bin/python run-tests.py $(TESTFLAGS) cd tests && $(HGPYTHONS)/$*/bin/python run-tests.py $(TESTFLAGS)
check-code: check-code:
hg manifest | xargs python contrib/check-code.py hg manifest | xargs python contrib/check-code.py
format-c: format-c:
clang-format --style file -i \ clang-format --style file -i \
`hg files 'set:(**.c or **.h) and not "listfile:contrib/clang-format-blacklist"'` `hg files 'set:(**.c or **.cc or **.h) and not "listfile:contrib/clang-format-blacklist"'`
update-pot: i18n/hg.pot update-pot: i18n/hg.pot
i18n/hg.pot: $(PYFILES) $(DOCFILES) i18n/posplit i18n/hggettext i18n/hg.pot: $(PYFILES) $(DOCFILES) i18n/posplit i18n/hggettext
$(PYTHON) i18n/hggettext mercurial/commands.py \ $(PYTHON) i18n/hggettext mercurial/commands.py \
hgext/*.py hgext/*/__init__.py \ hgext/*.py hgext/*/__init__.py \
mercurial/fileset.py mercurial/revset.py \ mercurial/fileset.py mercurial/revset.py \
mercurial/templatefilters.py mercurial/templatekw.py \ mercurial/templatefilters.py mercurial/templatekw.py \

tests/test-check-clang-format.t

#require clang-format test-repo #require clang-format test-repo
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ cd "$TESTDIR"/.. $ cd "$TESTDIR"/..
$ for f in `testrepohg files 'set:(**.c or **.h) and not "listfile:contrib/clang-format-blacklist"'` ; do $ for f in `testrepohg files 'set:(**.c or **.cc or **.h) and not "listfile:contrib/clang-format-blacklist"'` ; do
> clang-format --style file $f > $f.formatted > clang-format --style file $f > $f.formatted
> cmp $f $f.formatted || diff -u $f $f.formatted > cmp $f $f.formatted || diff -u $f $f.formatted
> rm $f.formatted > rm $f.formatted
> done > done