This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1877

bdiff: Handle the possibility of an integer overflow when allocating
ClosedPublic

Authored by alex_gaynor on Jan 17 2018, 4:37 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGcf2e2a7399bc: bdiff: handle the possibility of an integer overflow when allocating

Diff Detail

Repository
rHG Mercurial
Branch
alloc-overflow (bookmark) on default (branch)
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

alex_gaynor created this revision.Jan 17 2018, 4:37 PM
durin42 accepted this revision.Jan 17 2018, 4:40 PM
durin42 added a subscriber: durin42.

Thanks!

This revision is now accepted and ready to land.Jan 17 2018, 4:40 PM
indygreg added a subscriber: indygreg.Jan 17 2018, 4:42 PM
indygreg added inline comments.
mercurial/bdiff.c
44

Memory throughput is already a bottleneck in bdiff code. Is there an impact on hg perfbdiff with the change from malloc() to calloc()?

durin42 added a comment.Jan 17 2018, 4:47 PM

Before:

! wall 0.002096 comb 0.000000 user 0.000000 sys 0.000000 (best of 1329)

After:

! wall 0.002094 comb 0.000000 user 0.000000 sys 0.000000 (best of 1355)

so, uh, calloc is slightly faster? but not enough to even matter.

durin42 added a comment.Jan 17 2018, 4:49 PM

Wait, I'm a moron, I forgot to do ./hg instead of hg. New results:

Before:

! wall 0.002058 comb 0.000000 user 0.000000 sys 0.000000 (best of 1293)

After:

! wall 0.002107 comb 0.000000 user 0.000000 sys 0.000000 (best of 1342)

so calloc() is very slightly slower, but it's so little I'm not inclined to sweat it.

Closed by commit rHGcf2e2a7399bc: bdiff: handle the possibility of an integer overflow when allocating (authored by alex_gaynor). · Explain WhyJan 17 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bdiff.c (2 lines)

Diff 4858

mercurial/bdiff.c

/* count the lines */ /* count the lines */
i = 1; /* extra line for sentinel */ i = 1; /* extra line for sentinel */
for (p = a; p < plast; p++) for (p = a; p < plast; p++)
if (*p == '\n') if (*p == '\n')
i++; i++;
if (p == plast) if (p == plast)
i++; i++;
*lr = l = (struct bdiff_line *)malloc(sizeof(struct bdiff_line) * i); *lr = l = (struct bdiff_line *)calloc(i, sizeof(struct bdiff_line));
indygregUnsubmitted
Not Done

Memory throughput is already a bottleneck in bdiff code. Is there an impact on hg perfbdiff with the change from malloc() to calloc()?

indygreg: Memory throughput is already a bottleneck in bdiff code. Is there an impact on `hg perfbdiff`…
if (!l) if (!l)
return -1; return -1;
/* build the line array and calculate hashes */ /* build the line array and calculate hashes */
hash = 0; hash = 0;
for (p = a; p < plast; p++) { for (p = a; p < plast; p++) {
hash = HASH(hash, *p); hash = HASH(hash, *p);