( )⚙ D1883 tests: get run-tests to reliably hand shellquote a string and not a bytes

This is an archive of the discontinued Mercurial Phabricator instance.

tests: get run-tests to reliably hand shellquote a string and not a bytes
ClosedPublic

Authored by durin42 on Jan 18 2018, 8:38 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 18 2018, 8:38 AM
durin42 updated this revision to Diff 5039.Feb 1 2018, 3:04 PM
indygreg accepted this revision.Feb 1 2018, 3:29 PM
indygreg added a subscriber: indygreg.

This patch didn't seem correct to me at first because str is a different type in Python 2 and 3. But if the desired result is to get a bytes, then the logic does seem to check out.

This revision is now accepted and ready to land.Feb 1 2018, 3:29 PM
This revision was automatically updated to reflect the committed changes.