This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1886

commands: replace map() with list comprehension
ClosedPublic

Authored by durin42 on Jan 18 2018, 8:38 AM.

Details

Reviewers
pulkit
indygreg
Group Reviewers
hg-reviewers
Commits
rHG56891a790012: commands: replace map() with list comprehension
rHG81ee8d21f0d1: commands: replace map() with list comprehension
Summary

This will work identically on Python 2 and 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 18 2018, 8:38 AM
pulkit accepted this revision.Jan 18 2018, 8:46 AM
durin42 updated this revision to Diff 4947.Jan 19 2018, 3:11 PM
durin42 updated this revision to Diff 5041.Feb 1 2018, 3:05 PM
indygreg accepted this revision.Feb 1 2018, 3:31 PM
This revision is now accepted and ready to land.Feb 1 2018, 3:31 PM
Closed by commit rHG81ee8d21f0d1: commands: replace map() with list comprehension (authored by durin42). · Explain WhyFeb 1 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (2 lines)

Diff 5057

mercurial/commands.py

raise error.Abort(_("repository does not support bundle version %s") % raise error.Abort(_("repository does not support bundle version %s") %
cgversion) cgversion)
if base: if base:
if dest: if dest:
raise error.Abort(_("--base is incompatible with specifying " raise error.Abort(_("--base is incompatible with specifying "
"a destination")) "a destination"))
common = [repo.lookup(rev) for rev in base] common = [repo.lookup(rev) for rev in base]
heads = map(repo.lookup, revs) if revs else None heads = [repo.lookup(r) for r in revs] if revs else None
outgoing = discovery.outgoing(repo, common, heads) outgoing = discovery.outgoing(repo, common, heads)
else: else:
dest = ui.expandpath(dest or 'default-push', dest or 'default') dest = ui.expandpath(dest or 'default-push', dest or 'default')
dest, branches = hg.parseurl(dest, opts.get('branch')) dest, branches = hg.parseurl(dest, opts.get('branch'))
other = hg.peer(repo, opts, dest) other = hg.peer(repo, opts, dest)
revs, checkout = hg.addbranchrevs(repo, repo, branches, revs) revs, checkout = hg.addbranchrevs(repo, repo, branches, revs)
heads = revs and map(repo.lookup, revs) or revs heads = revs and map(repo.lookup, revs) or revs
outgoing = discovery.findcommonoutgoing(repo, other, outgoing = discovery.findcommonoutgoing(repo, other,