This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1917

scmutil: 0-pad transaction report callback category
ClosedPublic

Authored by martinvonz on Jan 19 2018, 3:51 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG963a611b2f39: scmutil: 0-pad transaction report callback category
Summary

Before this patch, the transaction name was '%2i-txnreport', which
means the first one would be ' 0-txnreport'. It seems more intuitive
for sorting purposes (the callbacks are called in lexicographical
order) to make it 0-padded.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 19 2018, 3:51 PM
durin42 accepted this revision.Jan 19 2018, 3:59 PM
This revision is now accepted and ready to land.Jan 19 2018, 3:59 PM
Closed by commit rHG963a611b2f39: scmutil: 0-pad transaction report callback category (authored by martinvonz). · Explain WhyJan 19 2018, 4:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (2 lines)

Diff 4957

mercurial/scmutil.py

# repository through the weakref. # repository through the weakref.
filtername = repo.filtername filtername = repo.filtername
reporef = weakref.ref(repo.unfiltered()) reporef = weakref.ref(repo.unfiltered())
def wrapped(tr): def wrapped(tr):
repo = reporef() repo = reporef()
if filtername: if filtername:
repo = repo.filtered(filtername) repo = repo.filtered(filtername)
func(repo, tr) func(repo, tr)
newcat = '%2i-txnreport' % len(categories) newcat = '%02i-txnreport' % len(categories)
otr.addpostclose(newcat, wrapped) otr.addpostclose(newcat, wrapped)
categories.append(newcat) categories.append(newcat)
return wrapped return wrapped
if txmatch(_reportobsoletedsource): if txmatch(_reportobsoletedsource):
@reportsummary @reportsummary
def reportobsoleted(repo, tr): def reportobsoleted(repo, tr):
obsoleted = obsutil.getobsoleted(repo, tr) obsoleted = obsutil.getobsoleted(repo, tr)