Page MenuHomePhabricator

p4fastimport: import purged files as empty files
Needs ReviewPublic

Authored by hollisb on Jan 23 2018, 8:31 PM.

Details

Reviewers
dsp
quark
durham
durin42
Group Reviewers
Restricted Project
Summary

P4 may preserve only the most recent copy of a file's data, automatically
"purging" the file data from older changelists when a new one is submitted.
That data is gone, and can't be accessed even from P4.

When importing such a file, we create an empty file so we can record that it
existed (e.g. which changelist introduced it).

Therefore, we include it in the list of filelogs we import, and we record that
changelists modified the file too. The file just has empty contents in the
older changesets.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

hollisb created this revision.Jan 23 2018, 8:31 PM
Herald added a reviewer: Restricted Project. ยท View Herald TranscriptJan 23 2018, 8:31 PM
hollisb added a reviewer: dsp.Jan 23 2018, 8:32 PM

Hi, I still need this. Since my P4 repo has "purged" changesets, I can't import without this patch.

durin42 resigned from this revision.Feb 11 2019, 1:00 PM

This is on Facebook's extensions repository, which I don't own. At this point, it probably makes sense to move p4fastimport to its own repository and maintain it there.