This is an archive of the discontinued Mercurial Phabricator instance.

patch: avoid repeated binary checks if all files in a patch are text
ClosedPublic

Authored by joerg.sonnenberger on Jan 25 2018, 5:36 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Do we have some numbers about how many seconds we win on big diffs?

I haven't seen a performance difference for regular runs, but it does show up in profiles, so eliminating it avoids wasting mental power by developers down the line.

This revision was automatically updated to reflect the committed changes.