This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1955

bundlespec: add support for some variants
ClosedPublic

Authored by lothiraldan on Jan 31 2018, 11:25 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGa2b350d9f6ae: bundlespec: add support for some variants
Summary

This way the stream v2 bundle spec can disable the changegroup part while
enabling the stream v2 part.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Jan 31 2018, 11:25 AM
indygreg accepted this revision.Mar 19 2018, 5:21 PM
indygreg added a subscriber: indygreg.

This looks reasonable to me.

I'll hold off landing due to requirements on an earlier, not yet accepted patch.

This revision is now accepted and ready to land.Mar 19 2018, 5:21 PM
lothiraldan updated this revision to Diff 7377.Mar 30 2018, 8:55 AM
indygreg accepted this revision.Mar 30 2018, 1:11 PM
Closed by commit rHGa2b350d9f6ae: bundlespec: add support for some variants (authored by lothiraldan). · Explain WhyMar 30 2018, 1:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/exchange.py (14 lines)
Mtests/test-stream-bundle-v2.t (10 lines)

Diff 5027

mercurial/exchange.py

}, },
'v2': { 'v2': {
'changegroup': True, 'changegroup': True,
'obsolescence': False, 'obsolescence': False,
'phases': False 'phases': False
} }
} }
_bundlespecvariants = {"streamv2": {"changegroup": False, "streamv2": True}}
# Compression engines allowed in version 1. THIS SHOULD NEVER CHANGE. # Compression engines allowed in version 1. THIS SHOULD NEVER CHANGE.
_bundlespecv1compengines = {'gzip', 'bzip2', 'none'} _bundlespecv1compengines = {'gzip', 'bzip2', 'none'}
def parsebundlespec(repo, spec, strict=True, externalnames=False): def parsebundlespec(repo, spec, strict=True, externalnames=False):
"""Parse a bundle string specification into parts. """Parse a bundle string specification into parts.
Bundle specifications denote a well-defined bundle/exchange format. Bundle specifications denote a well-defined bundle/exchange format.
The content of a given specification should not change over time in The content of a given specification should not change over time in
requirements = set(params['requirements'].split(',')) requirements = set(params['requirements'].split(','))
missingreqs = requirements - repo.supportedformats missingreqs = requirements - repo.supportedformats
if missingreqs: if missingreqs:
raise error.UnsupportedBundleSpecification( raise error.UnsupportedBundleSpecification(
_('missing support for repository features: %s') % _('missing support for repository features: %s') %
', '.join(sorted(missingreqs))) ', '.join(sorted(missingreqs)))
# Compute contentops based on the version # Compute contentops based on the version
contentops = _bundlespeccontentops.get(version, {}).copy() contentops = _bundlespeccontentops.get(version, {}).copy()
# Process the variants
if "stream" in params and params["stream"] == "v2":
variant = _bundlespecvariants["streamv2"]
contentops.update(variant)
if not externalnames: if not externalnames:
engine = util.compengines.forbundlename(compression) engine = util.compengines.forbundlename(compression)
compression = engine.bundletype()[1] compression = engine.bundletype()[1]
version = _bundlespeccgversions[version] version = _bundlespeccgversions[version]
# Set the cg.version # Set the cg.version
contentops["cg.version"] = version contentops["cg.version"] = version
version = part.params['version'] version = part.params['version']
if version in ('01', '02'): if version in ('01', '02'):
version = 'v2' version = 'v2'
else: else:
raise error.Abort(_('changegroup version %s does not have ' raise error.Abort(_('changegroup version %s does not have '
'a known bundlespec') % version, 'a known bundlespec') % version,
hint=_('try upgrading your Mercurial ' hint=_('try upgrading your Mercurial '
'client')) 'client'))
elif part.type == 'stream2' and version is None:
# A stream2 part requires to be part of a v2 bundle
version = "v2"
requirements = urlreq.unquote(part.params['requirements'])
params = _formatrequirementsparams(requirements.split())
return 'none-v2;stream=v2;%s' % params
if not version: if not version:
raise error.Abort(_('could not identify changegroup version in ' raise error.Abort(_('could not identify changegroup version in '
'bundle')) 'bundle'))
return '%s-%s' % (comp, version) return '%s-%s' % (comp, version)
elif isinstance(b, streamclone.streamcloneapplier): elif isinstance(b, streamclone.streamcloneapplier):
requirements = streamclone.readbundle1header(fh)[2] requirements = streamclone.readbundle1header(fh)[2]

tests/test-stream-bundle-v2.t

> C > C
> | > |
> B > B
> | > |
> A > A
> EOF > EOF
$ hg bundle -a --type="none-v2;stream=v2" bundle.hg $ hg bundle -a --type="none-v2;stream=v2" bundle.hg
5 changesets found
$ hg debugbundle bundle.hg $ hg debugbundle bundle.hg
Stream params: {} Stream params: {}
changegroup -- {nbchanges: 5, version: 02} stream2 -- {bytecount: 1693, filecount: 11, requirements: dotencode%2Cfncache%2Cgeneraldelta%2Crevlogv1%2Cstore}
426bada5c67598ca65036d57d9e4b64b0c1ce7a0
112478962961147124edd43549aedd1a335e44bf
26805aba1e600a82e93661149f2313866a221a7b
f585351a92f85104bff7c284233c338b10eb1df7
9bc730a19041f9ec7cb33c626e811aa233efb18c
$ hg debugbundle --spec bundle.hg $ hg debugbundle --spec bundle.hg
none-v2 none-v2;stream=v2;requirements%3Ddotencode%2Cfncache%2Cgeneraldelta%2Crevlogv1%2Cstore