This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1961

testrunner: fix updating of .testtimes file
ClosedPublic

Authored by martinvonz on Feb 1 2018, 12:19 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG69d7fcd91696: testrunner: fix updating of .testtimes file
rHG32675dbbec99: testrunner: fix updating of .testtimes file
Summary

We attempt to write the 5 most recent test timings to a file called
.testtimes, but we read previous results from a file called
.testtimes- (including the hyphen), so we ended up no more than a
single time per test.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Feb 1 2018, 12:19 PM
durin42 accepted this revision.Feb 1 2018, 5:36 PM
This revision is now accepted and ready to land.Feb 1 2018, 5:36 PM
Closed by commit rHG32675dbbec99: testrunner: fix updating of .testtimes file (authored by martinvonz). · Explain WhyFeb 1 2018, 5:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)

Diff 5035

tests/run-tests.py

# Save the most recent 5 wall-clock runtimes of each test to a # Save the most recent 5 wall-clock runtimes of each test to a
# human-readable text file named .testtimes. Tests are sorted # human-readable text file named .testtimes. Tests are sorted
# alphabetically, while times for each test are listed from oldest to # alphabetically, while times for each test are listed from oldest to
# newest. # newest.
def loadtimes(outputdir): def loadtimes(outputdir):
times = [] times = []
try: try:
with open(os.path.join(outputdir, b'.testtimes-')) as fp: with open(os.path.join(outputdir, b'.testtimes')) as fp:
for line in fp: for line in fp:
m = re.match('(.*?) ([0-9. ]+)', line) m = re.match('(.*?) ([0-9. ]+)', line)
times.append((m.group(1), times.append((m.group(1),
[float(t) for t in m.group(2).split()])) [float(t) for t in m.group(2).split()]))
except IOError as err: except IOError as err:
if err.errno != errno.ENOENT: if err.errno != errno.ENOENT:
raise raise
return times return times