This is an archive of the discontinued Mercurial Phabricator instance.

Differential D201

tests: clarify that duplicate flag processors is not an error
ClosedPublic

Authored by martinvonz on Jul 31 2017, 7:58 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG41081364addb: tests: clarify that duplicate flag processors is not an error
Summary

The flag processors test for duplicate processors for a single flag
was misleading because the file from the previous test case caused it
to fail (making the "echo 'this should fail' > file" part
irrelevant). Let's remove the leftover from the previous test case to
make it clear that duplicate flag processors results only in a
warning.

Note that duplicate flag processors would have resulted in a failure
(not just a warning) until ea1c2eb7abd3 (extensions: catch uisetup and
extsetup failures and don't let them break hg, 2017-06-06). I remember
expressing my concern about ending up with half-loaded extensions. It
would be pretty unfortunate to have double-encoded revlog content
enter a repo, so maybe we should reconsider?

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jul 31 2017, 7:58 PM
durin42 accepted this revision.Aug 1 2017, 3:52 PM
This revision is now accepted and ready to land.Aug 1 2017, 3:52 PM
Closed by commit rHG41081364addb: tests: clarify that duplicate flag processors is not an error (authored by martinvonz). · Explain WhyAug 1 2017, 3:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-flagprocessor.t (4 lines)

Diff 479

tests/test-flagprocessor.t

$ hg debugdata base64-gzip-noop 0 $ hg debugdata base64-gzip-noop 0
eJyLdnIMdjUziY12j/IMiI328/cPiOUCAESjBi4= (no-eol) eJyLdnIMdjUziY12j/IMiI328/cPiOUCAESjBi4= (no-eol)
# TEST: ensure a missing processor is handled # TEST: ensure a missing processor is handled
$ echo '[FAIL][BASE64][GZIP][NOOP]' > fail-base64-gzip-noop $ echo '[FAIL][BASE64][GZIP][NOOP]' > fail-base64-gzip-noop
$ hg commit -Aqm 'fail+base64+gzip+noop' $ hg commit -Aqm 'fail+base64+gzip+noop'
abort: missing processor for flag '0x1'! abort: missing processor for flag '0x1'!
[255] [255]
$ hg forget fail-base64-gzip-noop
$ rm fail-base64-gzip-noop
# TEST: ensure we cannot register several flag processors on the same flag # TEST: ensure we cannot register several flag processors on the same flag
$ cat >> .hg/hgrc << EOF $ cat >> .hg/hgrc << EOF
> [extensions] > [extensions]
> extension=$TESTDIR/flagprocessorext.py > extension=$TESTDIR/flagprocessorext.py
> duplicate=$TESTDIR/flagprocessorext.py > duplicate=$TESTDIR/flagprocessorext.py
> EOF > EOF
$ echo 'this should fail' > file $ echo 'this should fail' > file
$ hg commit -Aqm 'add file' $ hg commit -Aqm 'add file'
*** failed to set up extension duplicate: cannot register multiple processors on flag '0x8'. *** failed to set up extension duplicate: cannot register multiple processors on flag '0x8'.
abort: missing processor for flag '0x1'!
[255]
$ cd .. $ cd ..
# TEST: bundle repo # TEST: bundle repo
$ hg init bundletest $ hg init bundletest
$ cd bundletest $ cd bundletest
$ cat >> .hg/hgrc << EOF $ cat >> .hg/hgrc << EOF