This is an archive of the discontinued Mercurial Phabricator instance.

utils: copy util.py as utils/dateutil.py
AbandonedPublic

Authored by lothiraldan on Feb 5 2018, 11:22 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Summary

We will extract all date-related utils functions from util.py to
utils/dateutil.py in later changesets. First copy the util.py for blame
preservation.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Feb 5 2018, 11:22 AM
durin42 requested changes to this revision.Feb 7 2018, 5:21 PM
durin42 added a subscriber: durin42.

Can we do all of D2048::D2056 as a single change? What you've done means we have no useful blame information on everything done in D2049::D0256...

This revision now requires changes to proceed.Feb 7 2018, 5:21 PM

Can we do all of D2048::D2056 as a single change? What you've done means we have no useful blame information on everything done in D2049::D0256...

Moving function one by one proved very useful in the past when refactoring like this triggered subtle bugs in core or extension. Having each move on its changeset make it easier to bisect the part that breaks other and save a great amount of time when that happens.

Can we do all of D2048::D2056 as a single change? What you've done means we have no useful blame information on everything done in D2049::D0256...

Moving function one by one proved very useful in the past when refactoring like this triggered subtle bugs in core or extension. Having each move on its changeset make it easier to bisect the part that breaks other and save a great amount of time when that happens.

Life's tough. I care more about the blame history on this code.

(Other reviewers are welcome to overrule me, but I don't find this argument even slightly convincing.)

I've resent the series as https://phab.mercurial-scm.org/D2282 as a single changeset. I've included a note for extension authors with a link to the old series to more easily bisect the changeset breaking their extension.

Do you think it would be hard to update blame to work in the current case?

I've resent the series as https://phab.mercurial-scm.org/D2282 as a single changeset. I've included a note for extension authors with a link to the old series to more easily bisect the changeset breaking their extension.
Do you think it would be hard to update blame to work in the current case?

I think it's probably a significant amount of work to record sub-file-level copy information. It'd be of value, but I'm deeply skeptical it's worth the amount of time it'd take.

lothiraldan abandoned this revision.Mar 3 2018, 2:09 PM