This is an archive of the discontinued Mercurial Phabricator instance.

bundle2: add the capability to store hookargs on bundle operation object
ClosedPublic

Authored by pulkit on Aug 1 2017, 8:07 PM.

Details

Summary

There are extensions like pushrebase, pushvars which run hooks on a server
before taking the lock. Since the lock is not taken, transaction is not there,
so the hookargs can't be stored on the transaction. Adding hooksargs to bundle
operation object will help in running hooks before taking the lock.

This is a part of moving fb's extension bundle2hooks to core.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Aug 1 2017, 8:07 PM
durin42 accepted this revision.Aug 2 2017, 11:15 AM
This revision is now accepted and ready to land.Aug 2 2017, 11:15 AM
This revision was automatically updated to reflect the committed changes.