This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2092

wireprotoserver: add version to SSH protocol names (API)
ClosedPublic

Authored by indygreg on Feb 8 2018, 12:21 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGac33dc94e1d5: wireprotoserver: add version to SSH protocol names (API)
Summary

We recently introduced version 2 of the SSH protocol. Like we
did for the peer, we will need to differentiate version 1 and 2
of the server. So, we add version components to the advertised
name of the protocol handler.

Nothing in core looks for the old value. But an extension may.

.. api::

SSH protocol handler now advertises its name internally as
"ssh-v1" instead of "ssh."

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 8 2018, 12:21 AM
durin42 accepted this revision.Feb 12 2018, 4:25 PM
This revision is now accepted and ready to land.Feb 12 2018, 4:25 PM
Closed by commit rHGac33dc94e1d5: wireprotoserver: add version to SSH protocol names (API) (authored by indygreg). · Explain WhyFeb 12 2018, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotoserver.py (2 lines)

Diff 5536

mercurial/wireprotoserver.py

"""Handler for requests services via version 1 of SSH protocol.""" """Handler for requests services via version 1 of SSH protocol."""
def __init__(self, ui, fin, fout): def __init__(self, ui, fin, fout):
self._ui = ui self._ui = ui
self._fin = fin self._fin = fin
self._fout = fout self._fout = fout
@property @property
def name(self): def name(self):
return 'ssh' return SSHV1
def getargs(self, args): def getargs(self, args):
data = {} data = {}
keys = args.split() keys = args.split()
for n in xrange(len(keys)): for n in xrange(len(keys)):
argline = self._fin.readline()[:-1] argline = self._fin.readline()[:-1]
arg, l = argline.split() arg, l = argline.split()
if arg not in keys: if arg not in keys: