This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2099

infinitepush: delete the hack to load the extension after remotenames
ClosedPublic

Authored by pulkit on Feb 9 2018, 6:45 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGecdd8c3044de: infinitepush: delete the hack to load the extension after remotenames
Summary

The remotenames extension which circumvents the default push implementation
lives outside the core, so let's delete logic related to loading of extension on
the basis of remotenames ext.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 9 2018, 6:45 AM
indygreg accepted this revision.Feb 9 2018, 10:04 PM
This revision is now accepted and ready to land.Feb 9 2018, 10:04 PM
Closed by commit rHGecdd8c3044de: infinitepush: delete the hack to load the extension after remotenames (authored by pulkit). · Explain WhyMar 30 2018, 3:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/infinitepush/__init__.py (8 lines)

Diff 7414

hgext/infinitepush/__init__.py

def _isserver(ui): def _isserver(ui):
return ui.configbool('infinitepush', 'server') return ui.configbool('infinitepush', 'server')
def reposetup(ui, repo): def reposetup(ui, repo):
if _isserver(ui) and repo.local(): if _isserver(ui) and repo.local():
repo.bundlestore = bundlestore(repo) repo.bundlestore = bundlestore(repo)
def uisetup(ui):
# remotenames circumvents the default push implementation entirely, so make
# sure we load after it so that we wrap it.
order = extensions._order
order.remove('infinitepush')
order.append('infinitepush')
extensions._order = order
def extsetup(ui): def extsetup(ui):
commonsetup(ui) commonsetup(ui)
if _isserver(ui): if _isserver(ui):
serverextsetup(ui) serverextsetup(ui)
else: else:
clientextsetup(ui) clientextsetup(ui)
def commonsetup(ui): def commonsetup(ui):