This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	durin42	D20 check-code: prohibit `if False` antipattern
Closed	durin42	D19 convert: remove `if False` block
Closed	durin42	D18 filterpyflakes: move self-test into test file

Diff 36

	(r'raise Exception', "don't raise generic exceptions"),			(r'raise Exception', "don't raise generic exceptions"),
	(r'raise [^,(]+, ($[^$]+\)\|[^,]+)$',			(r'raise [^,(]+, ($[^$]+\)\|[^,]+)$',
	"don't use old-style two-argument raise, use Exception(message)"),			"don't use old-style two-argument raise, use Exception(message)"),
	(r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),			(r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),
	(r' [=!]=\s+(True\|False\|None)',			(r' [=!]=\s+(True\|False\|None)',
	"comparison with singleton, use 'is' or 'is not' instead"),			"comparison with singleton, use 'is' or 'is not' instead"),
	(r'^\s*(while\|if) [01]:',			(r'^\s*(while\|if) [01]:',
	"use True/False for constant Boolean expression"),			"use True/False for constant Boolean expression"),
				(r'^\s*if False(:\| +and)', 'Remove code instead of using `if False`'),
				krbullockUnsubmitted Not Done Cool regex bro krbullock: Cool regex bro
	(r'(?:(?<!def)\s+\|\()hasattr\(',			(r'(?:(?<!def)\s+\|\()hasattr\(',
	'hasattr(foo, bar) is broken on py2, use util.safehasattr(foo, bar) '			'hasattr(foo, bar) is broken on py2, use util.safehasattr(foo, bar) '
	'instead', r'#.*hasattr-py3-only'),			'instead', r'#.*hasattr-py3-only'),
	(r'opener$[^)]*$.read\(',			(r'opener$[^)]*$.read\(',
	"use opener.read() instead"),			"use opener.read() instead"),
	(r'opener$[^)]*$.write\(',			(r'opener$[^)]*$.write\(',
	"use opener.write() instead"),			"use opener.write() instead"),
	(r'[\s$](open\|file)\([^)]*$\.read\(',			(r'[\s$](open\|file)\([^)]*$\.read\(',