This is an archive of the discontinued Mercurial Phabricator instance.

charencode: allow clang-format oversight
ClosedPublic

Authored by durin42 on Feb 12 2018, 10:44 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Feb 12 2018, 10:44 AM
indygreg requested changes to this revision.Feb 12 2018, 2:20 PM
indygreg added a subscriber: indygreg.

I want a second opinion about the #include order.

mercurial/cext/charencode.h
11–12 ↗(On Diff #5491)

Huh? Why is it putting a system include after a local include? This feels wrong to me.

This revision now requires changes to proceed.Feb 12 2018, 2:20 PM
durin42 added inline comments.Feb 12 2018, 3:10 PM
mercurial/cext/charencode.h
11–12 ↗(On Diff #5491)

Per a colleague, https://clang.llvm.org/docs/ClangFormatStyleOptions.html - look for IncludeCategories.

Basically, it looks like we need to configure that. :/

durin42 updated this revision to Diff 5748.Feb 14 2018, 9:15 PM
indygreg accepted this revision.Feb 14 2018, 11:39 PM
This revision is now accepted and ready to land.Feb 14 2018, 11:39 PM
This revision was automatically updated to reflect the committed changes.