This is an archive of the discontinued Mercurial Phabricator instance.

narrowrepo: filter() is a generator on py3, wrap in list()
ClosedPublic

Authored by durin42 on Feb 13 2018, 11:13 AM.

Details

Summary

Was at the top of Python 3 exceptions.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 13 2018, 11:13 AM
indygreg accepted this revision.Feb 13 2018, 12:13 PM
indygreg added a subscriber: indygreg.

I'm not sure if there are performance implications to this. But if there are, this will get addressed when this code moves to core.

This revision is now accepted and ready to land.Feb 13 2018, 12:13 PM
This revision was automatically updated to reflect the committed changes.