Page MenuHomePhabricator

py3: use pycompat.bytestr to convert int/bytes to bytes
AbandonedPublic

Authored by pulkit on Feb 14 2018, 6:25 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Summary

The item value can be integer or can be bytes, so cannot use "%d" here.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 14 2018, 6:25 AM
yuja requested changes to this revision.Feb 14 2018, 8:14 AM
yuja added a subscriber: yuja.

The item value can be integer or can be bytes, so cannot use "%d" here.

Sounds like a bug. IIUC, the item should be a byte string because it is
passed to ui.progress(item=). Can you take a look?

This revision now requires changes to proceed.Feb 14 2018, 8:14 AM
pulkit abandoned this revision.Mon, Nov 11, 7:49 AM