This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2294

hgweb: open server logs in binary mode
ClosedPublic

Authored by durin42 on Feb 17 2018, 1:41 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG46c97973ee46: hgweb: open server logs in binary mode
rHGd527803576b2: hgweb: open server logs in binary mode
Summary

This is consistent with when we're logging to stdout, so we don't have
to do something annoyingly complicated in the logging infrastructure.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 17 2018, 1:41 AM
pulkit accepted this revision.Feb 17 2018, 4:40 AM
Closed by commit rHGd527803576b2: hgweb: open server logs in binary mode (authored by durin42). · Explain WhyFeb 17 2018, 4:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/server.py (2 lines)

Diff 5805

mercurial/hgweb/server.py

if util.safehasattr(os, "fork"): if util.safehasattr(os, "fork"):
_mixin = socketserver.ForkingMixIn _mixin = socketserver.ForkingMixIn
else: else:
class _mixin(object): class _mixin(object):
pass pass
def openlog(opt, default): def openlog(opt, default):
if opt and opt != '-': if opt and opt != '-':
return open(opt, 'a') return open(opt, 'ab')
return default return default
class MercurialHTTPServer(_mixin, httpservermod.httpserver, object): class MercurialHTTPServer(_mixin, httpservermod.httpserver, object):
# SO_REUSEADDR has broken semantics on windows # SO_REUSEADDR has broken semantics on windows
if pycompat.iswindows: if pycompat.iswindows:
allow_reuse_address = 0 allow_reuse_address = 0