( )⚙ D232 treemanifest: move tree store setup to a function

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D232

treemanifest: move tree store setup to a function
ClosedPublic

Authored by durham on Aug 4 2017, 5:54 PM.
Tags
None
Subscribers
None

Details

Reviewers
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGX3f9b75fcbb35: treemanifest: move tree store setup to a function
Summary

In a future patch we will move tree store setup to be part of manifestlog
creation, instead of part of repo setup. Let's move the logic to it's own
function for now.

Test Plan

Ran the tests

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Tests OK

Event Timeline

durham created this revision.Aug 4 2017, 5:54 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 4 2017, 5:54 PM
ryanmce accepted this revision.Aug 6 2017, 4:38 AM
This revision is now accepted and ready to land.Aug 6 2017, 4:38 AM
Closed by commit rFBHGX3f9b75fcbb35: treemanifest: move tree store setup to a function (authored by durham). · Explain WhyAug 9 2017, 3:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtreemanifest/__init__.py (33 lines)

Diff 563

treemanifest/__init__.py

if not repo.ui.configbool('treemanifest', 'treeonly'): if not repo.ui.configbool('treemanifest', 'treeonly'):
# If we're not a pure-tree repo, we must be using fastmanifest to # If we're not a pure-tree repo, we must be using fastmanifest to
# provide the hybrid manifest implementation. # provide the hybrid manifest implementation.
try: try:
extensions.find('fastmanifest') extensions.find('fastmanifest')
except KeyError: except KeyError:
raise error.Abort(_("cannot use treemanifest without fastmanifest")) raise error.Abort(_("cannot use treemanifest without fastmanifest"))
setuptreestores(repo)
def setuptreestores(repo):
if repo.ui.configbool("treemanifest", "server"):
packpath = repo.vfs.join('cache/packs/%s' % PACK_CATEGORY)
# Data store
datastore = cstore.datapackstore(packpath)
revlogstore = manifestrevlogstore(repo)
repo.svfs.manifestdatastore = unioncontentstore(datastore, revlogstore)
# History store
historystore = historypackstore(repo.ui, packpath)
repo.svfs.manifesthistorystore = unionmetadatastore(
historystore,
revlogstore,
)
return
usecdatapack = repo.ui.configbool('remotefilelog', 'fastdatapack') usecdatapack = repo.ui.configbool('remotefilelog', 'fastdatapack')
packpath = shallowutil.getcachepackpath(repo, PACK_CATEGORY) packpath = shallowutil.getcachepackpath(repo, PACK_CATEGORY)
localpackpath = shallowutil.getlocalpackpath(repo.svfs.vfs.base, localpackpath = shallowutil.getlocalpackpath(repo.svfs.vfs.base,
PACK_CATEGORY) PACK_CATEGORY)
# Data store # Data store
_addmanifestgroup) _addmanifestgroup)
def _capabilities(orig, repo, proto): def _capabilities(orig, repo, proto):
caps = orig(repo, proto) caps = orig(repo, proto)
caps.append('gettreepack') caps.append('gettreepack')
return caps return caps
extensions.wrapfunction(wireproto, '_capabilities', _capabilities) extensions.wrapfunction(wireproto, '_capabilities', _capabilities)
packpath = repo.vfs.join('cache/packs/%s' % PACK_CATEGORY) setuptreestores(repo)
# Data store
datastore = cstore.datapackstore(packpath)
revlogstore = manifestrevlogstore(repo)
repo.svfs.manifestdatastore = unioncontentstore(datastore, revlogstore)
# History store
historystore = historypackstore(repo.ui, packpath)
repo.svfs.manifesthistorystore = unionmetadatastore(
historystore,
revlogstore,
)
def _addmanifestgroup(*args, **kwargs): def _addmanifestgroup(*args, **kwargs):
raise error.Abort(_("cannot push commits to a treemanifest transition " raise error.Abort(_("cannot push commits to a treemanifest transition "
"server without pushrebase")) "server without pushrebase"))
def getmanifestlog(orig, self): def getmanifestlog(orig, self):
if self.ui.configbool('treemanifest', 'treeonly'): if self.ui.configbool('treemanifest', 'treeonly'):
mfl = treeonlymanifestlog(self.svfs) mfl = treeonlymanifestlog(self.svfs)