This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2335

py3: use "%d" for integers instead of "%s"
ClosedPublic

Authored by pulkit on Feb 18 2018, 2:01 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG6d6bc544467a: py3: use "%d" for integers instead of "%s"
rHGadf867853dbf: py3: use "%d" for integers instead of "%s"

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 18 2018, 2:01 PM
durin42 accepted this revision.Feb 18 2018, 3:44 PM
This revision is now accepted and ready to land.Feb 18 2018, 3:44 PM
Closed by commit rHGadf867853dbf: py3: use "%d" for integers instead of "%s" (authored by pulkit). · Explain WhyFeb 18 2018, 3:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/config.py (4 lines)

Diff 5892

mercurial/config.py

try: try:
include(inc, remap=remap, sections=sections) include(inc, remap=remap, sections=sections)
break break
except IOError as inst: except IOError as inst:
if inst.errno != errno.ENOENT: if inst.errno != errno.ENOENT:
raise error.ParseError(_("cannot include %s (%s)") raise error.ParseError(_("cannot include %s (%s)")
% (inc, inst.strerror), % (inc, inst.strerror),
"%s:%s" % (src, line)) "%s:%d" % (src, line))
continue continue
if emptyre.match(l): if emptyre.match(l):
continue continue
m = sectionre.match(l) m = sectionre.match(l)
if m: if m:
section = m.group(1) section = m.group(1)
if remap: if remap:
section = remap.get(section, section) section = remap.get(section, section)
if sections and section not in sections: if sections and section not in sections:
continue continue
if self.get(section, name) is not None: if self.get(section, name) is not None:
self._data[section] = self._data[section].preparewrite() self._data[section] = self._data[section].preparewrite()
del self._data[section][name] del self._data[section][name]
self._unset.append((section, name)) self._unset.append((section, name))
continue continue
raise error.ParseError(l.rstrip(), ("%s:%s" % (src, line))) raise error.ParseError(l.rstrip(), ("%s:%d" % (src, line)))
def read(self, path, fp=None, sections=None, remap=None): def read(self, path, fp=None, sections=None, remap=None):
if not fp: if not fp:
fp = util.posixfile(path, 'rb') fp = util.posixfile(path, 'rb')
assert getattr(fp, 'mode', r'rb') == r'rb', ( assert getattr(fp, 'mode', r'rb') == r'rb', (
'config files must be opened in binary mode, got fp=%r mode=%r' % ( 'config files must be opened in binary mode, got fp=%r mode=%r' % (
fp, fp.mode)) fp, fp.mode))
self.parse(path, fp.read(), self.parse(path, fp.read(),