This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2343

largefiles: give some **opts some strkwargs love
ClosedPublic

Authored by durin42 on Feb 18 2018, 3:54 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG398e96f77aa3: largefiles: give some **opts some strkwargs love
rHGac2717966335: largefiles: give some **opts some strkwargs love
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 18 2018, 3:54 PM
indygreg accepted this revision.Feb 18 2018, 9:03 PM
This revision is now accepted and ready to land.Feb 18 2018, 9:03 PM
Closed by commit rHGac2717966335: largefiles: give some **opts some strkwargs love (authored by durin42). · Explain WhyFeb 18 2018, 9:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/largefiles/overrides.py (5 lines)

Diff 5911

hgext/largefiles/overrides.py

# The m._files and m._map attributes are not changed to the deleted list # The m._files and m._map attributes are not changed to the deleted list
# because that affects the m.exact() test, which in turn governs whether # because that affects the m.exact() test, which in turn governs whether
# or not the file name is printed, and how. Simply limit the original # or not the file name is printed, and how. Simply limit the original
# matches to those in the deleted status list. # matches to those in the deleted status list.
matchfn = m.matchfn matchfn = m.matchfn
m.matchfn = lambda f: f in s.deleted and matchfn(f) m.matchfn = lambda f: f in s.deleted and matchfn(f)
removelargefiles(repo.ui, repo, True, m, **opts) removelargefiles(repo.ui, repo, True, m, **pycompat.strkwargs(opts))
# Call into the normal add code, and any files that *should* be added as # Call into the normal add code, and any files that *should* be added as
# largefiles will be # largefiles will be
added, bad = addlargefiles(repo.ui, repo, True, matcher, **opts) added, bad = addlargefiles(repo.ui, repo, True, matcher,
**pycompat.strkwargs(opts))
# Now that we've handled largefiles, hand off to the original addremove # Now that we've handled largefiles, hand off to the original addremove
# function to take care of the rest. Make sure it doesn't do anything with # function to take care of the rest. Make sure it doesn't do anything with
# largefiles by passing a matcher that will ignore them. # largefiles by passing a matcher that will ignore them.
matcher = composenormalfilematcher(matcher, repo[None].manifest(), added) matcher = composenormalfilematcher(matcher, repo[None].manifest(), added)
return orig(repo, matcher, prefix, opts, dry_run, similarity) return orig(repo, matcher, prefix, opts, dry_run, similarity)
# Calling purge with --all will cause the largefiles to be deleted. # Calling purge with --all will cause the largefiles to be deleted.
# Override repo.status to prevent this from happening. # Override repo.status to prevent this from happening.