This is an archive of the discontinued Mercurial Phabricator instance.

Differential D236

treemanifest: stop setting repo.svfs.manifestdatastore
ClosedPublic

Authored by durham on Aug 4 2017, 6:32 PM.
Tags
None
Subscribers
None

Details

Reviewers
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGX13f47fdcb0d0: treemanifest: stop setting repo.svfs.manifestdatastore
Summary

Now that all the users of the datastore access it via manifestlog, let's remove
the setters for the old repo.svfs version

Test Plan

Ran the tests

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Tests OK

Event Timeline

durham created this revision.Aug 4 2017, 6:32 PM
ryanmce accepted this revision.Aug 6 2017, 4:41 AM
This revision is now accepted and ready to land.Aug 6 2017, 4:41 AM
Closed by commit rFBHGX13f47fdcb0d0: treemanifest: stop setting repo.svfs.manifestdatastore (authored by durham). · Explain WhyAug 9 2017, 3:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtreemanifest/__init__.py (9 lines)

Diff 576

treemanifest/__init__.py

# History store # History store
historystore = historypackstore(repo.ui, packpath) historystore = historypackstore(repo.ui, packpath)
mfl.historystore = unionmetadatastore( mfl.historystore = unionmetadatastore(
historystore, historystore,
revlogstore, revlogstore,
) )
repo.svfs.manifestdatastore = mfl.datastore
repo.svfs.manifesthistorystore = mfl.historystore
return return
usecdatapack = repo.ui.configbool('remotefilelog', 'fastdatapack') usecdatapack = repo.ui.configbool('remotefilelog', 'fastdatapack')
packpath = shallowutil.getcachepackpath(repo, PACK_CATEGORY) packpath = shallowutil.getcachepackpath(repo, PACK_CATEGORY)
localpackpath = shallowutil.getlocalpackpath(repo.svfs.vfs.base, localpackpath = shallowutil.getlocalpackpath(repo.svfs.vfs.base,
PACK_CATEGORY) PACK_CATEGORY)
localhistorystore, localhistorystore,
] ]
mfl.historystore = unionmetadatastore( mfl.historystore = unionmetadatastore(
sharedhistorystore, sharedhistorystore,
localhistorystore, localhistorystore,
writestore=localhistorystore, writestore=localhistorystore,
) )
repo.svfs.manifestdatastore = mfl.datastore
repo.svfs.manifesthistorystore = mfl.historystore
repo.svfs.sharedmanifesthistorystores = mfl.sharedhistorystores
repo.svfs.localmanifesthistorystores = mfl.localhistorystores
repo.svfs.sharedmanifestdatastores = mfl.shareddatastores
repo.svfs.localmanifestdatastores = mfl.localdatastores
class treemanifestlog(manifest.manifestlog): class treemanifestlog(manifest.manifestlog):
def __init__(self, opener, treemanifest=False): def __init__(self, opener, treemanifest=False):
assert treemanifest is False assert treemanifest is False
cachesize = 4 cachesize = 4
opts = getattr(opener, 'options', None) opts = getattr(opener, 'options', None)
if opts is not None: if opts is not None:
cachesize = opts.get('manifestcachesize', cachesize) cachesize = opts.get('manifestcachesize', cachesize)