This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2374

strip: don't reimplement any()
ClosedPublic

Authored by martinvonz on Feb 21 2018, 1:45 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG28a97cf212af: strip: don't reimplement any()
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Feb 21 2018, 1:45 PM
durin42 accepted this revision.Feb 21 2018, 3:37 PM
This revision is now accepted and ready to land.Feb 21 2018, 3:37 PM
Closed by commit rHG28a97cf212af: strip: don't reimplement any() (authored by martinvonz). · Explain WhyFeb 21 2018, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/strip.py (7 lines)

Diff 5960

hgext/strip.py

if not revs: if not revs:
raise error.Abort(_('empty revision set')) raise error.Abort(_('empty revision set'))
descendants = set(cl.descendants(revs)) descendants = set(cl.descendants(revs))
strippedrevs = revs.union(descendants) strippedrevs = revs.union(descendants)
roots = revs.difference(descendants) roots = revs.difference(descendants)
update = False
# if one of the wdir parent is stripped we'll need # if one of the wdir parent is stripped we'll need
# to update away to an earlier revision # to update away to an earlier revision
for p in repo.dirstate.parents(): update = any(p != nullid and cl.rev(p) in strippedrevs
if p != nullid and cl.rev(p) in strippedrevs: for p in repo.dirstate.parents())
update = True
break
rootnodes = set(cl.node(r) for r in roots) rootnodes = set(cl.node(r) for r in roots)
q = getattr(repo, 'mq', None) q = getattr(repo, 'mq', None)
if q is not None and q.applied: if q is not None and q.applied:
# refresh queue state if we're about to strip # refresh queue state if we're about to strip
# applied patches # applied patches
if cl.rev(repo.lookup('qtip')) in strippedrevs: if cl.rev(repo.lookup('qtip')) in strippedrevs: