This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2386

narrowbundle2: drop legacy getcgkwargs variable
ClosedPublic

Authored by durin42 on Feb 21 2018, 11:25 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG0d5eaa97676b: narrowbundle2: drop legacy getcgkwargs variable
rHGeee738c5a899: narrowbundle2: drop legacy getcgkwargs variable
Summary

I think this was around as part of support for some older hg
internals. It's not needed any more.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 21 2018, 11:25 PM
indygreg accepted this revision.Feb 22 2018, 1:28 AM
This revision is now accepted and ready to land.Feb 22 2018, 1:28 AM
Closed by commit rHGeee738c5a899: narrowbundle2: drop legacy getcgkwargs variable (authored by durin42). · Explain WhyFeb 22 2018, 1:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowbundle2.py (3 lines)

Diff 5990

hgext/narrow/narrowbundle2.py

return packer.generate(common, visitnodes, False, source) return packer.generate(common, visitnodes, False, source)
# Serve a changegroup for a client with a narrow clone. # Serve a changegroup for a client with a narrow clone.
def getbundlechangegrouppart_narrow(bundler, repo, source, def getbundlechangegrouppart_narrow(bundler, repo, source,
bundlecaps=None, b2caps=None, heads=None, bundlecaps=None, b2caps=None, heads=None,
common=None, **kwargs): common=None, **kwargs):
cgversions = b2caps.get('changegroup') cgversions = b2caps.get('changegroup')
getcgkwargs = {}
if cgversions: # 3.1 and 3.2 ship with an empty value if cgversions: # 3.1 and 3.2 ship with an empty value
cgversions = [v for v in cgversions cgversions = [v for v in cgversions
if v in changegroup.supportedoutgoingversions(repo)] if v in changegroup.supportedoutgoingversions(repo)]
if not cgversions: if not cgversions:
raise ValueError(_('no common changegroup version')) raise ValueError(_('no common changegroup version'))
version = getcgkwargs['version'] = max(cgversions) version = max(cgversions)
else: else:
raise ValueError(_("server does not advertise changegroup version," raise ValueError(_("server does not advertise changegroup version,"
" can't negotiate support for ellipsis nodes")) " can't negotiate support for ellipsis nodes"))
include = sorted(filter(bool, kwargs.get('includepats', []))) include = sorted(filter(bool, kwargs.get('includepats', [])))
exclude = sorted(filter(bool, kwargs.get('excludepats', []))) exclude = sorted(filter(bool, kwargs.get('excludepats', [])))
newmatch = narrowspec.match(repo.root, include=include, exclude=exclude) newmatch = narrowspec.match(repo.root, include=include, exclude=exclude)
if not repo.ui.configbool("experimental", "narrowservebrokenellipses"): if not repo.ui.configbool("experimental", "narrowservebrokenellipses"):