( )⚙ D2412 py3: use "%d" for integers instead of "%s"

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2412

py3: use "%d" for integers instead of "%s"
ClosedPublic

Authored by pulkit on Feb 24 2018, 4:40 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG469c7e146c8f: py3: use "%d" for integers instead of "%s"
Summary

util.parsedate() returns a tuple of integers. Writing this patch, I wish we had
some type hinting.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 24 2018, 4:40 AM
yuja accepted this revision.Feb 24 2018, 5:27 AM
This revision is now accepted and ready to land.Feb 24 2018, 5:27 AM
Closed by commit rHG469c7e146c8f: py3: use "%d" for integers instead of "%s" (authored by pulkit). · Explain WhyFeb 24 2018, 5:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/mq.py (2 lines)

Diff 6036

hgext/mq.py

self.parseseries() self.parseseries()
self.seriesdirty = True self.seriesdirty = True
self.applieddirty = True self.applieddirty = True
nctx = repo[n] nctx = repo[n]
ph = patchheader(self.join(patchfn), self.plainmode) ph = patchheader(self.join(patchfn), self.plainmode)
if user: if user:
ph.setuser(user) ph.setuser(user)
if date: if date:
ph.setdate('%s %s' % date) ph.setdate('%d %d' % date)
ph.setparent(hex(nctx.p1().node())) ph.setparent(hex(nctx.p1().node()))
msg = nctx.description().strip() msg = nctx.description().strip()
if msg == defaultmsg.strip(): if msg == defaultmsg.strip():
msg = '' msg = ''
ph.setmessage(msg) ph.setmessage(msg)
p.write(bytes(ph)) p.write(bytes(ph))
if commitfiles: if commitfiles:
parent = self.qparents(repo, n) parent = self.qparents(repo, n)