This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2419

py3: use '%d' for integers instead of '%s'
ClosedPublic

Authored by pulkit on Feb 24 2018, 6:19 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGa24c57f1f5c3: py3: use '%d' for integers instead of '%s'
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 24 2018, 6:19 AM
yuja requested changes to this revision.Feb 24 2018, 7:57 AM
yuja added a subscriber: yuja.
yuja added inline comments.
mercurial/debugcommands.py
567

This one is bool.

This revision now requires changes to proceed.Feb 24 2018, 7:57 AM
pulkit updated this revision to Diff 6053.Feb 24 2018, 8:51 AM
yuja accepted this revision.Feb 24 2018, 8:24 PM
This revision is now accepted and ready to land.Feb 24 2018, 8:24 PM
Closed by commit rHGa24c57f1f5c3: py3: use '%d' for integers instead of '%s' (authored by pulkit). · Explain WhyFeb 24 2018, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (2 lines)
Mmercurial/tags.py (2 lines)

Diff 6066

mercurial/debugcommands.py

_('[-e] DATE [RANGE]'), _('[-e] DATE [RANGE]'),
norepo=True, optionalrepo=True) norepo=True, optionalrepo=True)
def debugdate(ui, date, range=None, **opts): def debugdate(ui, date, range=None, **opts):
"""parse and display a date""" """parse and display a date"""
if opts[r"extended"]: if opts[r"extended"]:
d = util.parsedate(date, util.extendeddateformats) d = util.parsedate(date, util.extendeddateformats)
else: else:
d = util.parsedate(date) d = util.parsedate(date)
ui.write(("internal: %s %s\n") % d) ui.write(("internal: %d %d\n") % d)
ui.write(("standard: %s\n") % util.datestr(d)) ui.write(("standard: %s\n") % util.datestr(d))
if range: if range:
m = util.matchdate(range) m = util.matchdate(range)
ui.write(("match: %s\n") % m(d[0])) ui.write(("match: %s\n") % m(d[0]))
yujaUnsubmitted
Not Done

This one is bool.

yuja: This one is bool.
@command('debugdeltachain', @command('debugdeltachain',
cmdutil.debugrevlogopts + cmdutil.formatteropts, cmdutil.debugrevlogopts + cmdutil.formatteropts,
_('-c|-m|FILE'), _('-c|-m|FILE'),
optionalrepo=True) optionalrepo=True)
def debugdeltachain(ui, repo, file_=None, **opts): def debugdeltachain(ui, repo, file_=None, **opts):
"""dump information about delta chains in a revlog """dump information about delta chains in a revlog

mercurial/tags.py

performance in cases where the line numbers are not needed. performance in cases where the line numbers are not needed.
''' '''
bintaghist = util.sortdict() bintaghist = util.sortdict()
hextaglines = util.sortdict() hextaglines = util.sortdict()
count = 0 count = 0
def dbg(msg): def dbg(msg):
ui.debug("%s, line %s: %s\n" % (fn, count, msg)) ui.debug("%s, line %d: %s\n" % (fn, count, msg))
for nline, line in enumerate(lines): for nline, line in enumerate(lines):
count += 1 count += 1
if not line: if not line:
continue continue
try: try:
(nodehex, name) = line.split(" ", 1) (nodehex, name) = line.split(" ", 1)
except ValueError: except ValueError: