This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2433

context: remove basectx.__int__ (API)
ClosedPublic

Authored by indygreg on Feb 24 2018, 2:30 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG38f480502043: context: remove basectx.__int__ (API)
Summary

basectx is the only type in the repo having int implemented.

This magic method can result in unexpected coercion. Furthermore,
having it implemented is wrong for some contexts, since rev() may
return None in some cases.

Previous commits removed known cases in core where contexts are
coerced to integers. So let's delete basectx.int.

This commit is a bit dangerous. While the test suite passes, there
are likely still some callers in core that rely on int that
don't have test coverage. An alternative would be to issue a
deprecation warning and let this bake for a few releases.

.. api::

context.basectx no longer implements __int__. Context instances
will no longer cast to ints. Consumers should call ``ctx.rev()``
instead.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 24 2018, 2:30 PM
yuja accepted this revision.Feb 24 2018, 8:36 PM
This revision is now accepted and ready to land.Feb 24 2018, 8:36 PM
yuja added a comment.Feb 24 2018, 8:39 PM

"While the test suite passes, there are likely still some callers in core
that rely on int that don't have test coverage."

I think we can fix them in next 2 months. Queued with delight, thanks.

Closed by commit rHG38f480502043: context: remove basectx.__int__ (API) (authored by indygreg). · Explain WhyFeb 24 2018, 8:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (3 lines)

Diff 6078

mercurial/context.py

return o return o
def __bytes__(self): def __bytes__(self):
return short(self.node()) return short(self.node())
__str__ = encoding.strmethod(__bytes__) __str__ = encoding.strmethod(__bytes__)
def __int__(self):
return self.rev()
def __repr__(self): def __repr__(self):
return r"<%s %s>" % (type(self).__name__, str(self)) return r"<%s %s>" % (type(self).__name__, str(self))
def __eq__(self, other): def __eq__(self, other):
try: try:
return type(self) == type(other) and self._rev == other._rev return type(self) == type(other) and self._rev == other._rev
except AttributeError: except AttributeError:
return False return False