This is an archive of the discontinued Mercurial Phabricator instance.

httppeer: explicitly catch urlerr.httperror and re-raise
ClosedPublic

Authored by durin42 on Feb 26 2018, 1:02 AM.

Details

Summary

On Python 3 it seems urllib.error.HTTPError doesn't set the .args
field of the exception to have any contents, which then breaks our
socket.error catch. This works around that issue.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 26 2018, 1:02 AM
This revision was automatically updated to reflect the committed changes.