This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2436

tests: add missing b prefixes in test-commit.t
ClosedPublic

Authored by durin42 on Feb 25 2018, 10:49 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGa39126a40be6: tests: add missing b prefixes in test-commit.t
Summary
  1. skip-blame just some b prefixes

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 25 2018, 10:49 PM
indygreg accepted this revision.Feb 26 2018, 12:36 AM
This revision is now accepted and ready to land.Feb 26 2018, 12:36 AM
Closed by commit rHGa39126a40be6: tests: add missing b prefixes in test-commit.t (authored by durin42). · Explain WhyFeb 26 2018, 12:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-commit.t (30 lines)

Diff 6094

tests/test-commit.t

empty commit empty commit
verify pathauditor blocks evil filepaths verify pathauditor blocks evil filepaths
$ cat > evil-commit.py <<EOF $ cat > evil-commit.py <<EOF
> from __future__ import absolute_import > from __future__ import absolute_import
> from mercurial import context, hg, node, ui as uimod > from mercurial import context, hg, node, ui as uimod
> notrc = u".h\u200cg".encode('utf-8') + '/hgrc' > notrc = u".h\u200cg".encode('utf-8') + b'/hgrc'
> u = uimod.ui.load() > u = uimod.ui.load()
> r = hg.repository(u, '.') > r = hg.repository(u, b'.')
> def filectxfn(repo, memctx, path): > def filectxfn(repo, memctx, path):
> return context.memfilectx(repo, memctx, path, > return context.memfilectx(repo, memctx, path,
> '[hooks]\nupdate = echo owned') > b'[hooks]\nupdate = echo owned')
> c = context.memctx(r, [r['tip'].node(), node.nullid], > c = context.memctx(r, [r[b'tip'].node(), node.nullid],
> 'evil', [notrc], filectxfn, 0) > b'evil', [notrc], filectxfn, 0)
> r.commitctx(c) > r.commitctx(c)
> EOF > EOF
$ $PYTHON evil-commit.py $ $PYTHON evil-commit.py
#if windows #if windows
$ hg co --clean tip $ hg co --clean tip
abort: path contains illegal component: .h\xe2\x80\x8cg\\hgrc (esc) abort: path contains illegal component: .h\xe2\x80\x8cg\\hgrc (esc)
[255] [255]
#else #else
$ hg co --clean tip $ hg co --clean tip
abort: path contains illegal component: .h\xe2\x80\x8cg/hgrc (esc) abort: path contains illegal component: .h\xe2\x80\x8cg/hgrc (esc)
[255] [255]
#endif #endif
$ hg rollback -f $ hg rollback -f
repository tip rolled back to revision 2 (undo commit) repository tip rolled back to revision 2 (undo commit)
$ cat > evil-commit.py <<EOF $ cat > evil-commit.py <<EOF
> from __future__ import absolute_import > from __future__ import absolute_import
> from mercurial import context, hg, node, ui as uimod > from mercurial import context, hg, node, ui as uimod
> notrc = "HG~1/hgrc" > notrc = b"HG~1/hgrc"
> u = uimod.ui.load() > u = uimod.ui.load()
> r = hg.repository(u, '.') > r = hg.repository(u, b'.')
> def filectxfn(repo, memctx, path): > def filectxfn(repo, memctx, path):
> return context.memfilectx(repo, memctx, path, > return context.memfilectx(repo, memctx, path,
> '[hooks]\nupdate = echo owned') > b'[hooks]\nupdate = echo owned')
> c = context.memctx(r, [r['tip'].node(), node.nullid], > c = context.memctx(r, [r[b'tip'].node(), node.nullid],
> 'evil', [notrc], filectxfn, 0) > b'evil', [notrc], filectxfn, 0)
> r.commitctx(c) > r.commitctx(c)
> EOF > EOF
$ $PYTHON evil-commit.py $ $PYTHON evil-commit.py
$ hg co --clean tip $ hg co --clean tip
abort: path contains illegal component: HG~1/hgrc abort: path contains illegal component: HG~1/hgrc
[255] [255]
$ hg rollback -f $ hg rollback -f
repository tip rolled back to revision 2 (undo commit) repository tip rolled back to revision 2 (undo commit)
$ cat > evil-commit.py <<EOF $ cat > evil-commit.py <<EOF
> from __future__ import absolute_import > from __future__ import absolute_import
> from mercurial import context, hg, node, ui as uimod > from mercurial import context, hg, node, ui as uimod
> notrc = "HG8B6C~2/hgrc" > notrc = b"HG8B6C~2/hgrc"
> u = uimod.ui.load() > u = uimod.ui.load()
> r = hg.repository(u, '.') > r = hg.repository(u, b'.')
> def filectxfn(repo, memctx, path): > def filectxfn(repo, memctx, path):
> return context.memfilectx(repo, memctx, path, > return context.memfilectx(repo, memctx, path,
> '[hooks]\nupdate = echo owned') > b'[hooks]\nupdate = echo owned')
> c = context.memctx(r, [r['tip'].node(), node.nullid], > c = context.memctx(r, [r[b'tip'].node(), node.nullid],
> 'evil', [notrc], filectxfn, 0) > b'evil', [notrc], filectxfn, 0)
> r.commitctx(c) > r.commitctx(c)
> EOF > EOF
$ $PYTHON evil-commit.py $ $PYTHON evil-commit.py
$ hg co --clean tip $ hg co --clean tip
abort: path contains illegal component: HG8B6C~2/hgrc abort: path contains illegal component: HG8B6C~2/hgrc
[255] [255]
# test that an unmodified commit template message aborts # test that an unmodified commit template message aborts