This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	6110		Feb 26 2018, 7:31 AM	★	★
Diff 2	6128		Feb 26 2018, 1:53 PM	★	★
Diff 3	6161	rHG3d58037c6ec0bce3222606e3d95d29d48bb9ff1f	Feb 26 2018, 5:53 AM	★	★

Status	Author	Revision
Closed	pulkit	D2460 py3: convert bytes to str using encoding.strfromlocal
Closed	pulkit	D2459 py3: use encoding.strtolocal() to convert str to bytes
Closed	pulkit	D2458 py3: use bytes instead of str in isinstance
Closed	pulkit	D2457 py3: slice over bytes or use .startswith() to prevent getting ascii values
Closed	pulkit	D2456 py3: convert a map expression into list comprehension
Closed	pulkit	D2455 py3: use '%d' for integers instead of '%s'
Closed	pulkit	D2454 py3: use email.generator module instead of email.Generator
Closed	pulkit	D2453 py3: use email.utils module instead of email.Utils
Closed	pulkit	D2452 py3: use pycompat.strkwargs to convert kwargs keys to str

Diff 6110


	# start			# start
	if date:			if date:
	start_time = util.parsedate(date)			start_time = util.parsedate(date)
	else:			else:
	start_time = util.makedate()			start_time = util.makedate()

	def genmsgid(id):			def genmsgid(id):
	return '<%s.%s@%s>' % (id[:20], int(start_time[0]), socket.getfqdn())			return '<%s.%d@%s>' % (id[:20], int(start_time[0]),
				pycompat.sysbytes(socket.getfqdn()))
				yujaUnsubmitted Not Done No idea what encoding is expected, but it could be `encoding.strtolocal()` assuming it was that in Python2. yuja: No idea what encoding is expected, but it could be `encoding.strtolocal()` assuming it was that…

	# deprecated config: patchbomb.from			# deprecated config: patchbomb.from
	sender = (opts.get('from') or ui.config('email', 'from') or			sender = (opts.get('from') or ui.config('email', 'from') or
	ui.config('patchbomb', 'from') or			ui.config('patchbomb', 'from') or
	prompt(ui, 'From', ui.username()))			prompt(ui, 'From', ui.username()))

	if bundle:			if bundle:
	stropts = pycompat.strkwargs(opts)			stropts = pycompat.strkwargs(opts)