| hg-reviewers |
os.devnull returns str on Python 3.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| if len(k) == 1: | if len(k) == 1: | ||||
| cmdline.append('' + v) | cmdline.append('' + v) | ||||
| else: | else: | ||||
| cmdline[-1] += '=' + v | cmdline[-1] += '=' + v | ||||
| except TypeError: | except TypeError: | ||||
| pass | pass | ||||
| cmdline = [util.shellquote(arg) for arg in cmdline] | cmdline = [util.shellquote(arg) for arg in cmdline] | ||||
| if not self.ui.debugflag: | if not self.ui.debugflag: | ||||
| cmdline += ['2>', os.devnull] | cmdline += ['2>', pycompat.bytestr(os.devnull)] | ||||
| cmdline = ' '.join(cmdline) | cmdline = ' '.join(cmdline) | ||||
| return cmdline | return cmdline | ||||
| def _run(self, cmd, *args, **kwargs): | def _run(self, cmd, *args, **kwargs): | ||||
| def popen(cmdline): | def popen(cmdline): | ||||
| p = subprocess.Popen(cmdline, shell=True, bufsize=-1, | p = subprocess.Popen(cmdline, shell=True, bufsize=-1, | ||||
| close_fds=util.closefds, | close_fds=util.closefds, | ||||
| stdout=subprocess.PIPE) | stdout=subprocess.PIPE) | ||||
| # Python versions since 2.7.1 do this extra quoting themselves | # Python versions since 2.7.1 do this extra quoting themselves | ||||
| return '"' + cmd + '"' | return '"' + cmd + '"' | ||||
| return cmd | return cmd | ||||
| def popen(command, mode='r'): | def popen(command, mode='r'): | ||||
| # Work around "popen spawned process may not write to stdout | # Work around "popen spawned process may not write to stdout | ||||
| # under windows" | # under windows" | ||||
| # http://bugs.python.org/issue1366 | # http://bugs.python.org/issue1366 | ||||
| command += " 2> %s" % os.devnull | command += " 2> %s" % pycompat.bytestr(os.devnull) | ||||
| return os.popen(quotecommand(command), mode) | return os.popen(quotecommand(command), mode) | ||||
| def explainexit(code): | def explainexit(code): | ||||
| return _("exited with status %d") % code, code | return _("exited with status %d") % code, code | ||||
| # if you change this stub into a real check, please try to implement the | # if you change this stub into a real check, please try to implement the | ||||
| # username and groupname functions above, too. | # username and groupname functions above, too. | ||||
| def isowner(st): | def isowner(st): | ||||