( )⚙ D2498 py3: use util.forcebytestr to convert str to bytes

This is an archive of the discontinued Mercurial Phabricator instance.

py3: use util.forcebytestr to convert str to bytes
ClosedPublic

Authored by pulkit on Feb 28 2018, 5:29 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 28 2018, 5:29 PM
yuja requested changes to this revision.Mar 1 2018, 4:37 AM
yuja added a subscriber: yuja.

Perhaps util.forcebytestr() is better because URLError is a subclass of IOError.

This revision now requires changes to proceed.Mar 1 2018, 4:37 AM
pulkit retitled this revision from py3: use pycompat.bytestr to convert str to bytes to py3: use util.forcebytestr to convert str to bytes.Mar 1 2018, 7:47 AM
pulkit updated this revision to Diff 6244.
yuja accepted this revision.Mar 1 2018, 8:26 AM
This revision is now accepted and ready to land.Mar 1 2018, 8:26 AM
This revision was automatically updated to reflect the committed changes.