This is an archive of the discontinued Mercurial Phabricator instance.

util: report integer result from write()
ClosedPublic

Authored by indygreg on Mar 3 2018, 9:52 AM.

Details

Summary

Python 2 sometimes returns None from write() calls. Python 3 doesn't.
This will make test output inconsistent between Python 2 and 3. So
let's paper over the differences by converting None to the length of
the result string.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 3 2018, 9:52 AM
durin42 accepted this revision.Mar 3 2018, 10:16 AM
This revision is now accepted and ready to land.Mar 3 2018, 10:16 AM
This revision was automatically updated to reflect the committed changes.