( )⚙ D260 chg: define _GNU_SOURCE to allow CentOS 5 compilation

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D260

chg: define _GNU_SOURCE to allow CentOS 5 compilation
ClosedPublic

Authored by Mathiasdm on Aug 7 2017, 8:19 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG5544af862286: chg: define _GNU_SOURCE to allow CentOS 5 compilation
Summary

Without this flag, compilation fails with:
hgclient.c: In function 'hgc_open':
hgclient.c:466: error: 'O_DIRECTORY' undeclared (first use in this function)
hgclient.c:466: error: (Each undeclared identifier is reported only once
hgclient.c:466: error: for each function it appears in.)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mathiasdm created this revision.Aug 7 2017, 8:19 AM
Mathiasdm abandoned this revision.Aug 7 2017, 8:22 AM

My mistake, I meant to send 2 changesets and forgot to modify the revset.

Mathiasdm reclaimed this revision.Aug 7 2017, 8:23 AM

Alright, it appears this does not work like I expected...

quark added a subscriber: quark.Aug 7 2017, 12:13 PM

Could you include the compiler error if _GNU_SOURCE is not set in commit message?

Mathiasdm edited the summary of this revision. (Show Details)Aug 8 2017, 2:25 AM
yuja accepted this revision as: yuja.Aug 8 2017, 8:24 AM
yuja added a subscriber: yuja.

Looks good. The manpage says

The O_CLOEXEC, O_DIRECTORY, and O_NOFOLLOW flags are not specified in POSIX.1-2001, but are specified in
POSIX.1-2008. Since glibc 2.12, one can obtain their definitions by defining either _POSIX_C_SOURCE with
a value greater than or equal to 200809L or _XOPEN_SOURCE with a value greater than or equal to 700. In
glibc 2.11 and earlier, one obtains the definitions by defining _GNU_SOURCE.

and the compiler error appears to be included in the commit message.

yuja added a comment.Aug 8 2017, 8:38 AM

I've queued these for stable so 4.3 rpm can be built for CentOS 5.

Closed by commit rHG5544af862286: chg: define _GNU_SOURCE to allow CentOS 5 compilation (authored by Mathiasdm). · Explain WhyAug 8 2017, 9:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/chg/Makefile (2 lines)

Diff 625

contrib/chg/Makefile

HG = $(CURDIR)/../../hg HG = $(CURDIR)/../../hg
TARGET = chg TARGET = chg
SRCS = chg.c hgclient.c procutil.c util.c SRCS = chg.c hgclient.c procutil.c util.c
OBJS = $(SRCS:.c=.o) OBJS = $(SRCS:.c=.o)
CFLAGS ?= -O2 -Wall -Wextra -pedantic -g CFLAGS ?= -O2 -Wall -Wextra -pedantic -g
CPPFLAGS ?= -D_FORTIFY_SOURCE=2 CPPFLAGS ?= -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE
override CFLAGS += -std=gnu99 override CFLAGS += -std=gnu99
ifdef HGPATH ifdef HGPATH
override CPPFLAGS += -DHGPATH=\"$(HGPATH)\" override CPPFLAGS += -DHGPATH=\"$(HGPATH)\"
endif endif
DESTDIR = DESTDIR =
PREFIX = /usr/local PREFIX = /usr/local
MANDIR = $(PREFIX)/share/man/man1 MANDIR = $(PREFIX)/share/man/man1