This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2646

setdiscovery: avoid a Yoda condition
ClosedPublic

Authored by martinvonz on Mar 4 2018, 11:58 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG59802fa590db: setdiscovery: avoid a Yoda condition
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 4 2018, 11:58 AM
indygreg accepted this revision.Mar 4 2018, 2:22 PM
This revision is now accepted and ready to land.Mar 4 2018, 2:22 PM
Closed by commit rHG59802fa590db: setdiscovery: avoid a Yoda condition (authored by martinvonz). · Explain WhyMar 4 2018, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/setdiscovery.py (2 lines)

Diff 6596

mercurial/setdiscovery.py

It is meant for initial sampling and focuses on querying heads and close It is meant for initial sampling and focuses on querying heads and close
ancestors of heads. ancestors of heads.
:dag: a dag object :dag: a dag object
:nodes: set of nodes to discover :nodes: set of nodes to discover
:size: the maximum size of the sample""" :size: the maximum size of the sample"""
sample = dag.headsetofconnecteds(nodes) sample = dag.headsetofconnecteds(nodes)
if size <= len(sample): if len(sample) >= size:
return _limitsample(sample, size) return _limitsample(sample, size)
_updatesample(dag, None, sample, quicksamplesize=size) _updatesample(dag, None, sample, quicksamplesize=size)
return sample return sample
def _takefullsample(dag, nodes, size): def _takefullsample(dag, nodes, size):
sample = dag.headsetofconnecteds(nodes) sample = dag.headsetofconnecteds(nodes)
# update from heads # update from heads
_updatesample(dag, nodes, sample) _updatesample(dag, nodes, sample)