( )⚙ D2667 obsolete: refactor function for getting obsolete options

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2667

obsolete: refactor function for getting obsolete options
ClosedPublic

Authored by indygreg on Mar 4 2018, 3:23 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd30810d09d6f: obsolete: refactor function for getting obsolete options
Summary

The function for returning obsolete option values obtains all
options, validates, then returns the option that was requested.

Let's create a new function to return all obsolete option values
so callers needing multiple values can call that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 4 2018, 3:23 PM
pulkit accepted this revision.Mar 27 2018, 3:10 AM
Closed by commit rHGd30810d09d6f: obsolete: refactor function for getting obsolete options (authored by indygreg). · Explain WhyMar 27 2018, 3:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/obsolete.py (29 lines)

Diff 7333

mercurial/obsolete.py

# Temporary hack for next check # Temporary hack for next check
newconfig = repo.ui.config('experimental', 'evolution.createmarkers') newconfig = repo.ui.config('experimental', 'evolution.createmarkers')
if newconfig: if newconfig:
result.add('createmarkers') result.add('createmarkers')
return option in result return option in result
def isenabled(repo, option): def getoptions(repo):
"""Returns True if the given repository has the given obsolete option """Returns dicts showing state of obsolescence features."""
enabled.
"""
createmarkersvalue = _getoptionvalue(repo, createmarkersopt) createmarkersvalue = _getoptionvalue(repo, createmarkersopt)
unstabluevalue = _getoptionvalue(repo, allowunstableopt) unstablevalue = _getoptionvalue(repo, allowunstableopt)
exchangevalue = _getoptionvalue(repo, exchangeopt) exchangevalue = _getoptionvalue(repo, exchangeopt)
# createmarkers must be enabled if other options are enabled # createmarkers must be enabled if other options are enabled
if ((unstabluevalue or exchangevalue) and not createmarkersvalue): if ((unstablevalue or exchangevalue) and not createmarkersvalue):
raise error.Abort(_("'createmarkers' obsolete option must be enabled " raise error.Abort(_("'createmarkers' obsolete option must be enabled "
"if other obsolete options are enabled")) "if other obsolete options are enabled"))
return _getoptionvalue(repo, option) return {
createmarkersopt: createmarkersvalue,
allowunstableopt: unstablevalue,
exchangeopt: exchangevalue,
}
def isenabled(repo, option):
"""Returns True if the given repository has the given obsolete option
enabled.
"""
return getoptions(repo)[option]
# Creating aliases for marker flags because evolve extension looks for # Creating aliases for marker flags because evolve extension looks for
# bumpedfix in obsolete.py # bumpedfix in obsolete.py
bumpedfix = obsutil.bumpedfix bumpedfix = obsutil.bumpedfix
usingsha256 = obsutil.usingsha256 usingsha256 = obsutil.usingsha256
## Parsing and writing of version "0" ## Parsing and writing of version "0"
# #