This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2672

archival: ensure file mode for gzipfile is sysstr
ClosedPublic

Authored by durin42 on Mar 4 2018, 4:13 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd3c231f8d27d: archival: ensure file mode for gzipfile is sysstr
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Mar 4 2018, 4:13 PM
pulkit accepted this revision.Mar 4 2018, 4:33 PM
Closed by commit rHGd3c231f8d27d: archival: ensure file mode for gzipfile is sysstr (authored by durin42). · Explain WhyMar 4 2018, 4:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/archival.py (3 lines)

Diff 6615

mercurial/archival.py

self.mtime = mtime self.mtime = mtime
self.fileobj = None self.fileobj = None
def taropen(mode, name='', fileobj=None): def taropen(mode, name='', fileobj=None):
if kind == 'gz': if kind == 'gz':
mode = mode[0:1] mode = mode[0:1]
if not fileobj: if not fileobj:
fileobj = open(name, mode + 'b') fileobj = open(name, mode + 'b')
gzfileobj = self.GzipFileWithTime(name, mode + 'b', gzfileobj = self.GzipFileWithTime(name,
pycompat.sysstr(mode + 'b'),
zlib.Z_BEST_COMPRESSION, zlib.Z_BEST_COMPRESSION,
fileobj, timestamp=mtime) fileobj, timestamp=mtime)
self.fileobj = gzfileobj self.fileobj = gzfileobj
return tarfile.TarFile.taropen( return tarfile.TarFile.taropen(
name, pycompat.sysstr(mode), gzfileobj) name, pycompat.sysstr(mode), gzfileobj)
else: else:
return tarfile.open( return tarfile.open(
name, pycompat.sysstr(mode + kind), fileobj) name, pycompat.sysstr(mode + kind), fileobj)